feat: Write colr atom to muxed MP4 when present in input AV1 file #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaitlinOCallaghan
changed the title
joeyparrish
approved these changes
Aug 2, 2023
| uint16_t transfer_characteristics, | ||
| uint16_t matrix_coefficients, | ||
| uint8_t video_full_range_flag) const { | ||
| return base::StringPrintf( |
There was a problem hiding this comment.
A link to https://aomediacodec.github.io/av1-isobmff/#codecsparam here would be really helpful, IMO
There was a problem hiding this comment.
The link is included above on line 76 - I think the default PR review port cut it off:
|
Now that #1205 this needs to be rebased |
CaitlinOCallaghan
force-pushed
the
cocallaghan/writing-colr-atom
branch
from
9f2b379
to
71d68b4
Compare
|
Rebased! :) @cosmin |
cosmin
approved these changes
Aug 5, 2023
cosmin
requested changes
Aug 5, 2023
| @@ -429,6 +430,36 @@ bool MP4Muxer::GenerateVideoTrak(const VideoStreamInfo* video_info, | |||
| VideoSampleEntry video; | |||
| video.format = | |||
| CodecToFourCC(video_info->codec(), video_info->h26x_stream_format()); | |||
| if (video.format == FOURCC_av01) { | |||
| auto av1_color_info = | |||
There was a problem hiding this comment.
having to parse these back out of the codec string doesn't feel like the right solution
|
Re-published as PR#1261, with an improved and more stable implementation. |
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an extension of the full AV1 codec string feature: PR 1205 and relates to Issue 1007 and Issue 1202.
As per the AV1 spec, the codec string may contain optional color values. These color values are critical for detecting HDR video streams - see Issue 1007. Color information is extracted from the input mp4's
colratom and used to generate the full AV1 codec string. This PR preserves the color information by writing thecolratom to the muxed mp4.References:
Specification - Section 6.4.2 Color config semantics (page 117)
Testing
Manual: AV1 video WITH colr atom
Note: Presence of the colr atom in
bbbhdr_av1.mp4was verified with a hex editor../out/Release/packager in=~/Downloads/bbbhdr_av1.mp4,stream=video,output=av1_with_colr.mp4 --mpd_output av1_with_colr.mpdav1_with_colr.mp4bitstream for thecolratom and cross reference the values of the atom's properties with the codec representation string found in the manifest:Format
git clang-format --style Chromium --binary /usr/bin/clang-format 80e024013df87a4bfeb265c8ea83cfa2a0c5db0f